linux-ext4 - Re: [PATCH V2] fix type of "offset" in ext4_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B647B95.7070206@redhat.com>
Date:	Sat, 30 Jan 2010 12:33:57 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	tytso@....edu
CC:	ext4 development <linux-ext4@...r.kernel.org>,
	Giel de Nijs <giel@...torwise.com>
Subject: Re: [PATCH V2] fix type of "offset" in ext4_io_end

tytso@....edu wrote:
> On Fri, Jan 29, 2010 at 02:28:23PM -0600, Eric Sandeen wrote:
>> The "offset" member in ext4_io_end holds bytes, not
>> blocks, so ext4_lblk_t is wrong - and too small (u32)
>>
>> This caused the testcase "Possible ext4 data corruption
>> with large files and async I/O" sent by Giel to fail when it
>> wrapped around to 0.
>>
>> Also fix up the type of arguments to
>> ext4_convert_unwritten_extents(), it gets ssize_t from
>> ext4_end_aio_dio_nolock() and ext4_ext_direct_IO()
>>
>> Reported-by: Giel de Nijs <giel@...torwise.com>
>> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
>> ---
> 
> This looks important enough (and low risk enough) to push to Linus
> before the next merge window.   Comments?
> 
> 						- Ted

yeah, I think so.

if there's any concern over the size_t type changes I could
split it up.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html