linux-ext4 - Re: [PATCH 08/23] vfs: Add a flag to denote posix mapped richacl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100201231858.GR19418@fieldses.org>
Date:	Mon, 1 Feb 2010 18:18:58 -0500
From:	"J. Bruce Fields" <bfields@...i.umich.edu>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	sfrench@...ibm.com, ffilz@...ibm.com, agruen@...e.de,
	adilger@....com, sandeen@...hat.com, tytso@....edu,
	staubach@...hat.com, jlayton@...hat.com,
	linux-fsdevel@...r.kernel.org, nfsv4@...ux-nfs.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 08/23] vfs: Add a flag to denote posix mapped richacl

On Mon, Feb 01, 2010 at 11:04:50AM +0530, Aneesh Kumar K.V wrote:
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> ---
>  fs/richacl_posix.c      |    7 +++++++
>  include/linux/richacl.h |   10 ++++++----
>  2 files changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/richacl_posix.c b/fs/richacl_posix.c
> index 07db970..3cf2124 100644
> --- a/fs/richacl_posix.c
> +++ b/fs/richacl_posix.c
> @@ -183,6 +183,13 @@ static void posix_to_richacl(struct posix_acl *pacl, int type,
>  	acl->a_group_mask = richacl_mode_to_mask(mode >> 3);
>  	acl->a_other_mask = richacl_mode_to_mask(mode);
>  
> +	/*
> +	 * Mark that the acl as mapped from posix
> +	 * This gives user space the chance to verify
> +	 * whether the mapping was correct
> +	 */

How would it use this information?  (And how could it be incorrect?)

--b.

> +	acl->a_flags |= ACL4_POSIX_MAPPED;
> +
>  	return;
>  }
>  
> diff --git a/include/linux/richacl.h b/include/linux/richacl.h
> index b08fdf1..41d93d8 100644
> --- a/include/linux/richacl.h
> +++ b/include/linux/richacl.h
> @@ -36,12 +36,14 @@ struct richacl {
>  #define ACL4_AUTO_INHERIT		0x01
>  #define ACL4_PROTECTED			0x02
>  #define ACL4_DEFAULTED			0x04
> +#define ACL4_POSIX_MAPPED		0x10
>  #define ACL4_WRITE_THROUGH		0x40
>  
> -#define ACL4_VALID_FLAGS ( \
> -	ACL4_AUTO_INHERIT | \
> -	ACL4_PROTECTED | \
> -	ACL4_DEFAULTED | \
> +#define ACL4_VALID_FLAGS (	\
> +	ACL4_AUTO_INHERIT |	\
> +	ACL4_PROTECTED |	\
> +	ACL4_DEFAULTED |	\
> +	ACL4_POSIX_MAPPED |	\
>  	ACL4_WRITE_THROUGH)
>  
>  /* e_type values */
> -- 
> 1.7.0.rc0.48.gdace5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html