linux-ext4 - [PATCH 2/4][2.6.32-stable] ext4: Handle -EDQUOT error on write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100206173921.ni6fmpki5ck8so0c@wwwmail.urz.uni-heidelberg.de>
Date:	Sat, 06 Feb 2010 17:39:21 +0100
From:	marcus.husar@...e.uni-heidelberg.de
To:	linux-ext4@...r.kernel.org
Subject: [PATCH 2/4][2.6.32-stable] ext4: Handle -EDQUOT error on write

This is a backport of 1db913823c0f8360fccbd24ca67eb073966a5ffd that
applies cleanly on top of patch 1 of this patchset.

ext4: Handle -EDQUOT error on write

We need to release the journal before we do a write_inode.  Otherwise
we could deadlock.

Signed-off-by: Marcus Husar <marcus.husar@...e.uni-heidelberg.de>
---
       inode.c |   32 ++++++++++++++++++--------------
       1 file changed, 18 insertions(+), 14 deletions(-)

diff -uprN a/fs/ext4/inode.c b/fs/ext4/inode.c
--- a/fs/ext4/inode.c	2010-02-05 09:55:16.068240000 +0100
+++ b/fs/ext4/inode.c	2010-02-05 10:52:12.148240610 +0100
@@ -1866,24 +1866,12 @@ repeat:
       	 * later. Real quota accounting is done at pages writeout
       	 * time.
       	 */
-	if (vfs_dq_reserve_block(inode, md_needed + 1)) {
-		/*
-		 * We tend to badly over-estimate the amount of
-		 * metadata blocks which are needed, so if we have
-		 * reserved any metadata blocks, try to force out the
-		 * inode and see if we have any better luck.
-		 */
-		if (md_reserved && retries++ <= 3)
-			goto retry;
+	if (vfs_dq_reserve_block(inode, md_needed + 1))
       		return -EDQUOT;
-	}

       	if (ext4_claim_free_blocks(sbi, md_needed + 1)) {
       		vfs_dq_release_reservation_block(inode, md_needed + 1);
       		if (ext4_should_retry_alloc(inode->i_sb, &retries)) {
-		retry:
-			if (md_reserved)
-				write_inode_now(inode, (retries == 3));
       			yield();
       			goto repeat;
       		}
@@ -3061,7 +3049,7 @@ static int ext4_da_write_begin(struct fi
       			       loff_t pos, unsigned len, unsigned flags,
       			       struct page **pagep, void **fsdata)
       {
-	int ret, retries = 0;
+	int ret, retries = 0, quota_retries = 0;
       	struct page *page;
       	pgoff_t index;
       	unsigned from, to;
@@ -3120,6 +3108,22 @@ retry:

       	if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries))
       		goto retry;
+
+	if ((ret == -EDQUOT) &&
+		EXT4_I(inode)->i_reserved_meta_blocks &&
+		(quota_retries++ < 3)) {
+		/*
+		 * Since we often over-estimate the number of meta
+		 * data blocks required, we may sometimes get a
+		 * spurios out of quota error even though there would
+		 * be enough space once we write the data blocks and
+		 * find out how many meta data blocks were _really_
+		 * required.  So try forcing the inode write to see if
+		 * that helps.
+		 */
+		write_inode_now(inode, (quota_retries == 3));
+		goto retry;
+	}
       out:
       	return ret;
       }





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html