lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100218012128.GA8897@atrey.karlin.mff.cuni.cz> Date: Thu, 18 Feb 2010 02:21:28 +0100 From: Jan Kara <jack@...e.cz> To: Dmitry Monakhov <dmonakhov@...nvz.org> Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org Subject: Re: [PATCH 06/19] ext2: replace inode uid,gid,mode initialization with helper function > > Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org> > --- > fs/ext2/ialloc.c | 12 ++++-------- > 1 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c > index 15387c9..4a4b132 100644 > --- a/fs/ext2/ialloc.c > +++ b/fs/ext2/ialloc.c > @@ -550,16 +550,12 @@ got: > > sb->s_dirt = 1; > mark_buffer_dirty(bh2); > - inode->i_uid = current_fsuid(); > - if (test_opt (sb, GRPID)) > + if (test_opt (sb, GRPID)) { As Andreas wrote, please don't use space after a function name. Otherwise the patch looks fine. Honza > + inode->i_mode = mode; > + inode->i_uid = current_fsuid(); > inode->i_gid = dir->i_gid; > - else if (dir->i_mode & S_ISGID) { > - inode->i_gid = dir->i_gid; > - if (S_ISDIR(mode)) > - mode |= S_ISGID; > } else > - inode->i_gid = current_fsgid(); > - inode->i_mode = mode; > + inode_init_owner(inode, dir, mode); > > inode->i_ino = ino; > inode->i_blocks = 0; > -- > 1.6.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara <jack@...e.cz> SuSE CR Labs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists