linux-ext4 - Re: [00/11] fix ext4 deadlock on 2.6.27.y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100228031635.GC1278@suse.de>
Date:	Sat, 27 Feb 2010 19:16:35 -0800
From:	Greg KH <gregkh@...e.de>
To:	"Jayson R. King" <dev@...sonking.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Stable team <stable@...nel.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	Mingming Cao <cmm@...ibm.com>, Theodore Ts'o <tytso@....edu>,
	linux-ext4@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [00/11] fix ext4 deadlock on 2.6.27.y

On Sat, Feb 27, 2010 at 12:22:19AM -0600, Jayson R. King wrote:
> Greetings,
> 
> Using the kernel 2.6.27.45 with an ext4 filesystem, the same deadlock as
> was reported earlier in kernel bugzilla #12579 can occur. Simply running
> "dbench 500" on an ext4 filesystem can cause the deadlock in one to two
> minutes.
> 
> In later stable kernels, the deadlock was fixed by commit 2acf2c26
> ("ext4: Implement range_cyclic in ext4_da_writepages instead of
> write_cache_pages"). I can confirm that the same commit fixes the
> deadlock on 2.6.27.y. However, as the code in ext4_da_writepages is
> different in 2.6.27.y than in later kernels, it was necessary to add
> some other mainline patches before 2acf2c26.
> 
> Alltogether, I've added 11 mainline patches including 2acf2c26 to my
> local 2.6.27.y kernel, and confirmed that the deadlock is fixed only
> when the patch 2acf2c26 is applied.
> 
> The 11 patches are:
> 
> Aneesh Kumar K.V (10):
>       ext4: invalidate pages if delalloc block allocation fails.
>       ext4: Make sure all the block allocation paths reserve blocks
>       ext4: Add percpu dirty block accounting.
>       ext4: Retry block reservation
>       ext4: Retry block allocation if we have free blocks left
>       ext4: Use tag dirty lookup during mpage_da_submit_io
>       vfs: Remove the range_cont writeback mode.
>       vfs: Add no_nrwrite_index_update writeback control flag
>       ext4: Fix file fragmentation during large file write.
>       ext4: Implement range_cyclic in ext4_da_writepages instead of write_cache_pages
> 
> Mingming Cao (1):
>       percpu counter: clean up percpu_counter_sum_and_set()
> 
> All will be posted in a reply to this message, in the order that they apply.
> 
> I think these patches should be committed to stable 2.6.27.y.

What do the ext4 maintainers think about this?  If they ack this, I'll
be glad to queue them up in the next release.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html