linux-ext4 - [PATCH 3/3] ext4: Code cleanup for EXT4_IOC_MOVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 03 Mar 2010 15:49:44 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	Theodore Tso <tytso@....edu>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH 3/3] ext4: Code cleanup for EXT4_IOC_MOVE_EXT ioctl

ext4: Code cleanup for EXT4_IOC_MOVE_EXT ioctl

From: Akira Fujita <a-fujita@...jp.nec.com>

a) Fix sparse warning in ext4_ioctl()
b) Remove unneeded variable in mext_leaf_block()
c) Fix spelling typo in mext_check_arguments()

Signed-off-by: Akira Fujita <a-fujita@...jp.nec.com>
---
  fs/ext4/ioctl.c       |    3 ++-
  fs/ext4/move_extent.c |    4 +---
  2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 406758b..6f8b4fd 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -270,7 +270,8 @@ setversion_out:
  		if (me.moved_len > 0)
  			file_remove_suid(donor_filp);

-		if (copy_to_user((struct move_extent *)arg, &me, sizeof(me)))
+		if (copy_to_user((struct move_extent __user *)arg, &me,
+							sizeof(me)))
  			err = -EFAULT;
  mext_out:
  		fput(donor_filp);
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 7e99f4e..aa5fe28 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -477,7 +477,6 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode,
  	struct ext4_extent *oext, *o_start, *o_end, *prev_ext;
  	struct ext4_extent new_ext, start_ext, end_ext;
  	ext4_lblk_t new_ext_end;
-	ext4_fsblk_t new_phys_end;
  	int oext_alen, new_ext_alen, end_ext_alen;
  	int depth = ext_depth(orig_inode);
  	int ret;
@@ -491,7 +490,6 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode,
  	new_ext.ee_len = dext->ee_len;
  	new_ext_alen = ext4_ext_get_actual_len(&new_ext);
  	new_ext_end = le32_to_cpu(new_ext.ee_block) + new_ext_alen - 1;
-	new_phys_end = ext_pblock(&new_ext) + new_ext_alen - 1;

  	/*
  	 * Case: original extent is first
@@ -932,7 +930,7 @@ out2:
  }

  /**
- * mext_check_argumants - Check whether move extent can be done
+ * mext_check_arguments - Check whether move extent can be done
   *
   * @orig_inode:		original inode
   * @donor_inode:	donor inode
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html