linux-ext4 - Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1268070371.5347.8.camel@bobble.smo.corp.google.com>
Date:	Mon, 08 Mar 2010 09:46:11 -0800
From:	Frank Mayhar <fmayhar@...gle.com>
To:	tytso@....edu
Cc:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_error()
	instead

On Sat, 2010-03-06 at 21:45 -0500, tytso@....edu wrote:
> On Sat, Mar 06, 2010 at 06:33:48PM +0530, Aneesh Kumar K. V wrote:
> > 
> > I guess ext4_error and ext4_warning are now not taking __func__. So we
> > to be consistant with thos i this this can be in lower case even though
> > they are #defines.
> 
> Or maybe we should rename them be EXT4_ERROR and EXT4_WARNING.  What
> do other people think?

I guess I'm joining the apathetic majority when I say that it doesn't
matter to me at all.  Keeping them as-is is fine.
-- 
Frank Mayhar <fmayhar@...gle.com>
Google, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html