linux-ext4 - Re: Bug#564084: debugfs: logdump -b<block> show incorrect allocation status in block bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100314230230.GB5340@thunk.org>
Date:	Sun, 14 Mar 2010 19:02:30 -0400
From:	tytso@....edu
To:	Anon Sricharoenchai <anon.hui@...il.com>, 564084@...s.debian.org
Cc:	control@...s.debian.org, linux-ext4@...r.kernel.org
Subject: Re: Bug#564084: debugfs: logdump -b<block> show incorrect
 allocation status in block  bitmap

tags 564084 +pending
thanks

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=564084

On Thu, Jan 07, 2010 at 10:57:25PM +0700, Anon Sricharoenchai wrote:
> 
> *** Please type your report below this line ***
> "logdump -b<block>" command in debugfs show incorrect allocation status
> in block bitmap

Thanks for reporting this bug.  I believe a much simpler fix for this
problem is:

diff --git a/debugfs/logdump.c b/debugfs/logdump.c
index 9a7108a..9364ce4 100644
--- a/debugfs/logdump.c
+++ b/debugfs/logdump.c
@@ -619,7 +619,7 @@ static void dump_metadata_block(FILE *out_file, struct journal_source *source,
 		int offset;
 
 		super = current_fs->super;
-		offset = ((fs_blocknr - super->s_first_data_block) %
+		offset = ((block_to_dump - super->s_first_data_block) %
 			  super->s_blocks_per_group);
 
 		fprintf(out_file, "    (block bitmap for block %u: "

				       	      	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html