linux-ext4 - [PATCH 1/1]ext4: cleanup a warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 16 Mar 2010 18:54:43 +0800
From:	Steven Liu <lingjiujianke@...il.com>
To:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: [PATCH 1/1]ext4: cleanup a warning

Hi Ted,

        I have get a warning, too,


fs/ext4/move_extent.c:478: warning: start_ext.ee_block may be used
uninitialized in this function

my compiler version:

gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


I think i'm not the first get this warning,then i make a patch for
this warning, can you fix it in?

Signed-off-by: Qi Liu (lingjiujianke@...il.com)

diff --git a/ext4/fs/ext4/move_extent.c.orig b/ext4/fs/ext4/move_extent.c
index aa5fe28..b399358 100644
--- a/ext4/fs/ext4/move_extent.c.orig
+++ b/ext4/fs/ext4/move_extent.c
@@ -481,6 +481,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode,
        int depth = ext_depth(orig_inode);
        int ret;

+       start_ext.ee_block = end_ext.ee_block = 0;
        o_start = o_end = oext = orig_path[depth].p_ext;
        oext_alen = ext4_ext_get_actual_len(oext);
        start_ext.ee_len = end_ext.ee_len = 0;




                                Qi Liu
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html