linux-ext4 - Re: [PATCH, RFC 3/3] ext4: Add option for squelching ext4 errors to prevent dmesg from filling up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7C462C5D-0B00-45A8-95A4-AEF74EBC534E@oracle.com>
Date:	Fri, 19 Mar 2010 16:56:13 -0600
From:	Andreas Dilger <andreas.dilger@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH, RFC 3/3] ext4: Add option for squelching ext4 errors to prevent dmesg from filling up

On 2010-03-18, at 18:50, Theodore Ts'o wrote:
> @@ -363,12 +363,19 @@ void ext4_error_inode(const char *function,  
> struct inode *inode,
> {
> 	va_list args;
>
> +	if (!ext4_test_inode_state(inode, EXT4_STATE_ERR_SQUELCHED) ||
> +	    !(EXT4_SB(inode->i_sb)->s_mount_flags & EXT4_MF_FS_SQUELCH)) {
> +		va_start(args, fmt);
> +		printk(KERN_CRIT "EXT4-fs error (device %s): %s: "
> +		       "inode #%lu: (comm %s) ",
> +		       inode->i_sb->s_id, function, inode->i_ino,
> +		       current->comm);
> +		vprintk(fmt, args);
> +		printk("\n");
> +		va_end(args);

Shouldn't this really be using ext4_msg()?

Cheers, Andreas
--
Andreas Dilger
Principal Engineer, Lustre Group
Oracle Corporation Canada Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html