linux-ext4 - [PATCH] ext4/super.c: Replace CONTIG_EXT{2,3}_FS by CONFIG_EXT{2,3}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Mar 2010 12:05:04 +0100
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	linux-ext4@...r.kernel.org
Cc:	"Theodore Ts'o" <tytso@....edu>, Jan Kara <jack@...e.cz>
Subject: [PATCH] ext4/super.c: Replace CONTIG_EXT{2,3}_FS by 
	CONFIG_EXT{2,3}_FS

Hi,

today I pulled ext4 for_linus GIT branch into linus-tree (2.6.24-rc2-git1).

Unfortunately, the build breaks here:
...
  CC [M]  fs/ext4/super.o
  CC [M]  sound/isa/wavefront/wavefront_fx.o
  CC [M]  drivers/ata/pata_acpi.o
fs/ext4/super.c: In function ‘ext4_fill_super’:
fs/ext4/super.c:2553: error: ‘ext3_fs_type’ undeclared (first use in
this function)
fs/ext4/super.c:2553: error: (Each undeclared identifier is reported only once
fs/ext4/super.c:2553: error: for each function it appears in.)
make[5]: *** [fs/ext4/super.o] Error 1
...

While investigating the problem I found several typos in fs/ext4/super.c.
One of them was introduced with:

commit 2c7532a9b5fc3c27775f59e28d5f1ee4b1a1052e
"ext4: Don't use delayed allocation by default when used instead of ext3"

Furthermore, I have set the following CONFIG_EXT*FS* parameters:

$ zgrep CONFIG_EXT /proc/config.gz | grep FS
CONFIG_EXT2_FS=m
CONFIG_EXT2_FS_XATTR=y
CONFIG_EXT2_FS_POSIX_ACL=y
CONFIG_EXT2_FS_SECURITY=y
# CONFIG_EXT2_FS_XIP is not set
CONFIG_EXT3_FS=m
CONFIG_EXT3_FS_XATTR=y
CONFIG_EXT3_FS_POSIX_ACL=y
CONFIG_EXT3_FS_SECURITY=y
CONFIG_EXT4_FS=m
CONFIG_EXT4_FS_XATTR=y
CONFIG_EXT4_FS_POSIX_ACL=y
CONFIG_EXT4_FS_SECURITY=y

My patch is not fixing the problem, just the typos.
Please have a closer look into it, thanks.

--
Sedat

[1] http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git;a=commit;h=2c7532a9b5fc3c27775f59e28d5f1ee4b1a1052e

View attachment "0001-ext4-super.c-Replace-CONTIG_EXT-2-3-_FS-by-CONFIG_EX.patch" of type "text/x-diff" (2004 bytes)