linux-ext4 - Re: [PATCH] ext4: try fast merge operation in ext4_mb_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Mar 2010 22:34:39 +0530
From:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	jing zhang <zj.barak@...il.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Cc:	"Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger@....com>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: try fast merge operation in
 ext4_mb_free_metadata()

On Wed, 24 Mar 2010 21:32:39 +0800, jing zhang <zj.barak@...il.com> wrote:
> From: Jing Zhang <zj.barak@...il.com>
> 
> Date: Wed Mar 24 21:30:22     2010
> 
> There may exist fast path for merge if merge-able.
> 
> Cc: Theodore Ts'o <tytso@....edu>
> Cc: Andreas Dilger <adilger@....com>
> Cc: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
> Signed-off-by: Jing Zhang <zj.barak@...il.com>
> 
> ---
> 
> --- linux-2.6.32/fs/ext4/mballoc.c	2009-12-03 11:51:22.000000000 +0800
> +++ ext4_mm_leak/mballoc7.c	2010-03-24 21:27:24.000000000 +0800
> @@ -4385,6 +4385,24 @@ ext4_mb_free_metadata(handle_t *handle,
>  		}
>  	}
> 
> +	if (parent) {
> +		/* let's try fast path */
> +		entry = rb_entry(parent, struct ext4_free_data, node);
> +		if (n == &parent->rb_left) {
> +			if (can_merge(new_entry, entry)) {
> +				entry->start_blk = new_entry->start_blk;
> +				entry->count += new_entry->count;
> +				/* and info the caller that new_entry is
> +				 * not used yet.
> +				 */
> +				return 0;

return 0 on success so you may want -1 here 

> +			}
> +		}
> +		else if (can_merge(entry, new_entry)) {
> +			entry->count += new_entry->count;
> +			return 0;
> +		}
> +	}
>  	rb_link_node(new_node, parent, n);
>  	rb_insert_color(new_node, &db->bb_free_root);
> --

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html