linux-ext4 - Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wrwzv732.fsf@linux.vnet.ibm.com>
Date:	Fri, 26 Mar 2010 13:38:01 +0530
From:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	jing zhang <zj.barak@...il.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Cc:	"Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger@....com>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in
 ext4_mb_normalize_group_request()

On Thu, 25 Mar 2010 22:54:21 +0800, jing zhang <zj.barak@...il.com> wrote:
> From: Jing Zhang <zj.barak@...il.com>
> 
> Date: Wed Mar 25  22:55:04   2010
> 
> Checking bug seems not at right place, and the function itself should
> be inlined.
> 
> Cc: Theodore Ts'o <tytso@....edu>
> Cc: Andreas Dilger <adilger@....com>
> Cc: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
> Cc: "Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
> Signed-off-by: Jing Zhang <zj.barak@...il.com>
> 
> ---
> 
> --- linux-2.6.32/fs/ext4/mballoc.c	2009-12-03 11:51:22.000000000 +0800
> +++ ext4_mm_leak/mballoc-10.c	2010-03-25 22:44:00.000000000 +0800
> @@ -2786,9 +2786,7 @@ out_err:
>  static void ext4_mb_normalize_group_request(struct ext4_allocation_context *ac)
>  {
>  	struct super_block *sb = ac->ac_sb;
> -	struct ext4_locality_group *lg = ac->ac_lg;
> 
> -	BUG_ON(lg == NULL);
>  	if (EXT4_SB(sb)->s_stripe)
>  		ac->ac_g_ex.fe_len = EXT4_SB(sb)->s_stripe;
>  	else

That BUG_ON is to ensure that the allocation context is actually having
a locality group which is needed for group allocation request.

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html