linux-ext4 - Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877hovdu4s.fsf@openvz.org>
Date:	Mon, 29 Mar 2010 19:28:51 +0400
From:	dmonakhov@...nvz.org
To:	Jan Kara <jack@...e.cz>
Cc:	linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

Jan Kara <jack@...e.cz> writes:

> On Mon 29-03-10 16:21:35, Jan Kara wrote:
>> On Fri 26-03-10 19:29:54, Dmitry Monakhov wrote:
>> > generic setattr implementation is no longer responsible for
>> > quota transfer so synlinks must be handled via ext2_setattr.
>>   Ah, good catch. I'll merge ext2 and ext3 patch.
>   BTW, you forgot to add your signed-off-by. I'll take the liberty
> of adding it but please confirm so that we don't set a bad precedens
> (this legal stuff is sensitive...).
yes. It was me (Dmitry Monakhov). 
Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
>
>  							Honza
>> > ---
>> >  fs/ext2/symlink.c |    2 ++
>> >  1 files changed, 2 insertions(+), 0 deletions(-)
>> > 
>> > diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
>> > index 4e2426e..565cf81 100644
>> > --- a/fs/ext2/symlink.c
>> > +++ b/fs/ext2/symlink.c
>> > @@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>> >  	.readlink	= generic_readlink,
>> >  	.follow_link	= page_follow_link_light,
>> >  	.put_link	= page_put_link,
>> > +	.setattr	= ext2_setattr,
>> >  #ifdef CONFIG_EXT2_FS_XATTR
>> >  	.setxattr	= generic_setxattr,
>> >  	.getxattr	= generic_getxattr,
>> > @@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>> >  const struct inode_operations ext2_fast_symlink_inode_operations = {
>> >  	.readlink	= generic_readlink,
>> >  	.follow_link	= ext2_follow_link,
>> > +	.setattr	= ext2_setattr,
>> >  #ifdef CONFIG_EXT2_FS_XATTR
>> >  	.setxattr	= generic_setxattr,
>> >  	.getxattr	= generic_getxattr,
>> > -- 
>> > 1.6.6.1
>> > 
>> -- 
>> Jan Kara <jack@...e.cz>
>> SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html