linux-ext4 - quota reservation fixes for -stable?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BB36BEC.2000207@redhat.com>
Date:	Wed, 31 Mar 2010 10:36:12 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
CC:	Jan Kara <jack@...e.cz>, Dmitry Monakhov <dmonakhov@...nvz.org>
Subject: quota reservation fixes for -stable?

I think we should get the following commits to -stable:

0a5a9c725512461d19397490f3adf29931dca1f2 quota: Fix warning when a delayed write happens before quota is enabled
c469070aea5a0ada45a836937c776fd3083dae2b quota: manage reserved space when quota is not active [v2]

without these, we're just racking up the score on kerneloops:

http://www.kerneloops.org/searchweek.php?search=dquot_claim_space

(I think this is a #1 all-time high for a kerneloops count ;)

Pretty sure the 2 commits above can be backported w/o other
dependencies, but maybe Jan & Dmitry can confirm.

I dug into this a little; at least on stock .32 Fedora, it's really
only hitting on a few files, but seems to hit every time they're written:
/var/log/messages, audit.log, etc - things that likely were written
prior to quota being enabled.  Perhaps this is a Fedora initscripts
bug... 

But check this out, with a modified .32 kernel with the above 2 commints,
and a change that reports which inodes were modified:

VFS (sda12): inode(s) 1064 
VFS (sda12): Writes happened before quota was turned on thus quota information is probably inconsistent. Please run quotacheck(8).

# find /etc -inum 1064
/etc/mtab

This sounds a little chicken-and-eggy to me!

Anyway, the above 2 commits should make things -significantly- better,
so w/o any objections, let's get them to -stable.

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html