linux-ext4 - Re: [PATCH] ext4_freeze: don't return to userspace with a mutex held

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 04 Apr 2010 19:43:41 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Theodore Tso <tytso@....EDU>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4_freeze: don't return to userspace with a mutex held

Theodore Tso wrote:
> On Apr 4, 2010, at 5:23 PM, Eric Sandeen wrote:
>> Well, there is __generic_file_aio_write doing vfs_check_frozen, but
>>  I thought there was more at the vfs level to stop things from
>> getting to the filesystem... *shrug* I see you put the patch in as
>> sent, it sounds right to me.
> 
> Yeah, it looks safe but it would be nice to do some testing to make
> sure there's nothing we missed.
> 
> I'm also vaguely worried whether the right thing will happen in
> no-journal mode, but it looks like it's better than what we had
> before (which clearly would have never worked in no journal mode), so
> I decided to let it pass.

I did go back up the callchain from where the old lock should have
caught it, so I think I've plugged the same holes that were protected
before.

> Testing the freeze functionality definitely needs to be done before
> we trust what happens in no journal mode, for sure.

Oh good point, hadn't even thought about nojournal mode & freeze.
Always nice to "accidentally" fix things ;)

-Eric

> 
> -- Ted
> 
> -- To unsubscribe from this list: send the line "unsubscribe
> linux-ext4" in the body of a message to majordomo@...r.kernel.org 
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html