linux-ext4 - Re: [PATCH] ext4: group cache is added in ext4_mb_discard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <l2jac8f92701004070558l26bcc892g5bb2dbe263e389d5@mail.gmail.com>
Date:	Wed, 7 Apr 2010 20:58:36 +0800
From:	jing zhang <zj.barak@...il.com>
To:	tytso@....edu
Cc:	Andreas Dilger <adilger@....com>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: group cache is added in ext4_mb_discard_preallocations()

2010/4/7, tytso@....edu <tytso@....edu>:
> On Thu, Apr 01, 2010 at 08:34:41PM +0800, jing zhang wrote:
>>
>> --- linux-2.6.32/fs/ext4/mballoc.c	2009-12-03 11:51:22.000000000 +0800
>> +++ ext4_mm_leak/mballoc-14.c	2010-04-01 20:35:58.000000000 +0800
>> @@ -4299,7 +4299,7 @@ repeat:
>>  		}
>>  	} else {
>>  		freed  = ext4_mb_discard_preallocations(sb, ac->ac_o_ex.fe_len);
>> -		if (freed)
>> +		if (freed && freed >= ac->ac_o_ex.fe_len)
>>  			goto repeat;
>>  		*errp = -ENOSPC;
>>  		ac->ac_b_ex.fe_len = 0;
>
> This is just wrong.
>
> Since you didn't give a justification, I'm not sure why you think it
> is correct.
>

Though freed, is the amount freed bigger than needed?
If not, it seems unnecessary to repeat.

      - zj
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html