linux-ext4 - Re: Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8EEE8A6D-343A-4514-BFC8-1EFEDE180B70@sun.com>
Date:	Wed, 28 Apr 2010 17:08:54 -0600
From:	Andreas Dilger <adilger@....com>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	Chris Mason <chris.mason@...cle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Theodore Ts'o" <tytso@....edu>, mfasheh@...e.com,
	Joel Becker <joel.becker@...cle.com>,
	Matthew Wilcox <matthew@....cx>, linux-btrfs@...r.kernel.org,
	"linux-kernel@...r.kernel.org Mailinglist" 
	<linux-kernel@...r.kernel.org>, linux-fsdevel@...r.kernel.org,
	linux-ext4 development <linux-ext4@...r.kernel.org>,
	ocfs2-devel@....oracle.com, linux-mm@...ck.org, ngupta@...are.org,
	Jeremy Fitzhardinge <jeremy@...p.org>, JBeulich@...ell.com,
	kurt.hackel@...cle.com, Nick Piggin <npiggin@...e.de>,
	dave.mccracken@...cle.com, Rik van Riel <riel@...hat.com>
Subject: Re: Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook

On 2010-04-22, at 07:29, Dan Magenheimer wrote:
> Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook
> 
> Filesystems must explicitly enable cleancache.  For ext4,
> all other cleancache hooks are in the VFS layer.
> 
> Signed-off-by: Dan Magenheimer <dan.magenheimer@...cle.com>

Given the minimal changes being done to ext3/ext4, I don't have any objection to this.  Being able to hook ext4 into SSDs for hierarchical caching is something that will become increasingly important for huge ext4 filesystems.

Acked-by: Andreas Dilger <adilger@....com>

> Diffstat:
> super.c                                  |    2 ++
> 1 file changed, 2 insertions(+)
> 
> --- linux-2.6.34-rc5/fs/ext4/super.c	2010-04-19 17:29:56.000000000 -0600
> +++ linux-2.6.34-rc5-cleancache/fs/ext4/super.c	2010-04-21 10:13:00.000000000 -0600
> @@ -39,6 +39,7 @@
>  #include <linux/ctype.h>
>  #include <linux/log2.h>
>  #include <linux/crc16.h>
> +#include <linux/cleancache.h>
>  #include <asm/uaccess.h>
>  
>  #include "ext4.h"
> @@ -1784,6 +1785,7 @@ static int ext4_setup_super(struct super
>  			EXT4_INODES_PER_GROUP(sb),
>  			sbi->s_mount_opt);
> 
> +	sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
>  	return res;
>  }


Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html