linux-ext4 - Re: [PATCH 04/11] jbd2: use NULL instead of 0 when pointer is needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1005111004390.28092@pobox.suse.cz>
Date:	Tue, 11 May 2010 10:05:00 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Bill Pemberton <wfp5p@...ginia.edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 04/11] jbd2:  use NULL instead of 0 when pointer is
 needed

On Fri, 30 Apr 2010, Bill Pemberton wrote:

> Fixes sparse warning:
> 
> fs/jbd2/journal.c:1892:9: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Bill Pemberton <wfp5p@...ginia.edu>
> CC: linux-ext4@...r.kernel.org
> ---
>  fs/jbd2/journal.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index c03d4dc..bc2ff59 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1889,7 +1889,7 @@ static struct kmem_cache *get_slab(size_t size)
>  	BUG_ON(i >= JBD2_MAX_SLABS);
>  	if (unlikely(i < 0))
>  		i = 0;
> -	BUG_ON(jbd2_slab[i] == 0);
> +	BUG_ON(jbd2_slab[i] == NULL);
>  	return jbd2_slab[i];
>  }

This doesn't seem to be picked up as per today's linux-next. I have 
applied the patch to my queue.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html