linux-ext4 - Re: [PATCH, RFC] support discard in non-journal ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BECCB9F.8070007@suse.de>
Date:	Fri, 14 May 2010 12:03:43 +0800
From:	Coly Li <coly.li@...e.de>
To:	Jiaying Zhang <jiayingz@...gle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH, RFC] support discard in non-journal ext4



On 05/14/2010 08:29 AM, Jiaying Zhang Wrote:
> On Thu, May 13, 2010 at 2:08 AM, Coly Li <coly.li@...e.de> wrote:
>>
>>
>> On 05/13/2010 01:00 PM, Jiaying Zhang Wrote:
>>> This patch issues discard request for freed blocks in ext4_free_blocks()
>>> if ext4 is mounted with discard option and without journal.
>>>
>>> Author: Jiaying Zhang <jiayingz@...gle.com>
>>> Date: � Wed May 12 21:11:46 2010 -0700
>>>
>>> � � Issue discard request in ext4_free_blocks() when ext4 has no journal and
>>> � � is mounted with discard option.
>>>
>>> � � Signed-off-by: Jiaying Zhang <jiayingz@...gle.com>
>>>
>>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>>> index a291cc3..d51b79a 100644
>>> --- a/fs/ext4/mballoc.c
>>> +++ b/fs/ext4/mballoc.c
>>> @@ -2513,6 +2513,22 @@ int ext4_mb_release(struct super_block *sb)
>>> � � � return 0;
>>> �}
>>>
>>> +static void ext4_issue_discard(struct super_block *sb, ext4_group_t block_group,
[snip]
>>
>> How about make it as an inline routine? Thanks.
> 
> Ok. I changed it to inline. The modified patch is attached.
> 

Acked-by: Coly Li <coly.li@...e.de>

Thanks.

-- 
Coly Li
SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html