linux-ext4 - Re: [PATCH] ext4: Use bitops to read/modify i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100601030608.GA4426@thunk.org>
Date:	Mon, 31 May 2010 23:06:08 -0400
From:	tytso@....edu
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: Use bitops to read/modify i_flags part2

On Mon, May 31, 2010 at 12:56:45PM +0400, Dmitry Monakhov wrote:
> Bad news. Bug still exist because you've missed several important chunks 
> (ext4_set_inode_flags, ext4_inode_blocks) while porting original patch.
> And I've missed this too on review cycle.
> Please add following patch to patch-queue.

What I should have insisted on (if I had time to review this sort of
patch earlier) is to split it up into that which could be implemented
via a perl script (i.e.):

#!/usr/bin/perl -i.bak

while (<>) {
    s/EXT4_I\(([^ ]*)\)->i_flags & EXT4_([^ ]*)_FL/ext4_test_inode_flag(\1, EXT4_INODE_\2)/;
    s/EXT4_I\(([^ ]*)\)->i_flags \|= EXT4_([^ ]*)_FL/ext4_set_inode_flag(\1, EXT4_INODE_\2)/;
    s/EXT4_I\(([^ ]*)\)->i_flags \&= ~EXT4_([^ ]*)_FL/ext4_clear_inode_flag(\1, EXT4_INODE_\2)/;
    print;
}

with a piece before and after it for the more complicated bits.  This
is why really large patches, really, *really* need to be split apart.
(Or needs to have enough description of what was being done where so
that I could split apart into more easily manageable --- and easily
backported to stable kernel -- pieces.)

But no worries, we'll treat this as the follow-on part of the patch,
and then add these to the additional stable series patches.  These
sorts of things happen, especially with these gigantic patches....

      	 			   	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html