linux-ext4 - Re: [PATCH] ext4: Use bitops to read/modify i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DB06625C-975E-4B03-8447-318DBEBE7BF8@mit.edu>
Date:	Thu, 3 Jun 2010 06:37:57 -0400
From:	Theodore Tso <tytso@....EDU>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: Use bitops to read/modify i_flags part2


On Jun 3, 2010, at 4:48 AM, Dmitry Monakhov wrote:

> tytso@....edu writes:
> 
>> On Mon, May 31, 2010 at 12:56:45PM +0400, Dmitry Monakhov wrote:
>>> "Theodore Ts'o" <tytso@....edu> writes:
>>> 
>>>> From: "Theodore Ts'o" <tytso@....edu>
>>>> 
>>>> From: Dmitry Monakhov <dmonakhov@...nvz.org>
>>> Bad news. Bug still exist because you've missed several important chunks 
>>> (ext4_set_inode_flags, ext4_inode_blocks) while porting original patch.
>>> And I've missed this too on review cycle.
>>> Please add following patch to patch-queue.
>> 
>> Added to the ext4 patch queue (with minor updates to the commit
>> description).
> BTW. The patch that i've sent would not compile because of misstype.
> So it may looks like that i've sent untested random peace of crap
> from a first glance. But the truth is that that misstype was fixed
> in to topmost quilt's patch so i've missed it original patch.
> And indeed the bug with non-atomic bit's manipulation has gone, at
> least i can't reproduce it any more. Incremental fix attached.

Yeah, I caught that.  It caused me to review that part of the patch much
more carefully, but no harm done.

-- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html