linux-ext4 - Re: [PATCH 4/8] e2fsprogs: Next3 snapshot control with chattr/lsattr -X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1F7FAC7E-3FCF-4E32-922D-02E7A068CC50@oracle.com>
Date:	Mon, 21 Jun 2010 12:17:49 -0600
From:	Andreas Dilger <andreas.dilger@...cle.com>
To:	Amir Goldstein <amir73il@...rs.sf.net>
Cc:	"linux-ext4@...r.kernel.org development" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 4/8] e2fsprogs: Next3 snapshot control with chattr/lsattr -X

> +static struct flags_name snapshot_flags_array[] = {
> +	{ NEXT3_SNAPFILE_LIST_FL, "S", "on_liSt" },
> +	{ NEXT3_SNAPFILE_ENABLED_FL, "n", "eNabled" },
> +	{ NEXT3_SNAPFILE_ACTIVE_FL, "a", "Active" },
> +	{ NEXT3_SNAPFILE_INUSE_FL, "p", "inuse_by_Previous" },
> +	{ NEXT3_SNAPFILE_DELETED_FL, "s", "Deleted" },
> +	{ NEXT3_SNAPFILE_SHRUNK_FL, "h", "sHrunk" },
> +	{ NEXT3_SNAPFILE_OPEN_FL, "o", "mOunted" },
> +	{ NEXT3_SNAPFILE_TAGGED_FL, "t", "Tagged" },
>  	{ 0, NULL, NULL }
>  };

While clever, I don't think this necessarily makes for a good user interface.
In comparison, flags "l, e, a, i, d, s, m ,t" respectively make much easier to understand/remember name abbreviations.

Cheers, Andreas
--
Andreas Dilger
Lustre Technical Lead
Oracle Corporation Canada Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html