linux-ext4 - Re: E2fsprogs master branch now has all 64-bit patch applied

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100621215950.96874n172zixms2s@mail.cs.ccu.edu.tw>
Date:	Mon, 21 Jun 2010 21:59:50 +0800
From:	陳炫廷 <acht93@...ccu.edu.tw>
To:	linux-ext4@...r.kernel.org
Subject: Re: E2fsprogs master branch now has all 64-bit patch applied

Hi Ted,

    Resize seems not work when the size is bigger than 16TB (offline resize).

My test machine:
x64 platform 2.6.32 kernel + this newest patch

1. <16TB ext4 enlarge to >16TB (offline)

     a. I use "8 x 2TB WD disks" and "mdadm" build linear raid
     b. then use mkfs.ext4 to make ext4 file system
     c. grow the linear raid to "10 X 2TB"
     d. finally it grow to "2.X TB" smaller than before

2. >16TB offline resize, the steps is similiar as before.
    a. I use "9 x 2TB WD disks" build linear raid
    b. mkfs.ext4 and not mount

    c. grow the linear raid to "10 X 2TB"
    d. do resize
    e. finally it grow to "2.X TB" smaller than before

*. Base on my trace, seems the "EXT4_FEATURE_INCOMPAT_64BIT"
not on when mkfs.ext4. So the new_size is wrong when do "resize",
*. When do resize,  "EXT2_FLAG_64BITS" not add to fs->flags.
So when execute "ext2fs_allocate_block_bitmap" function in resize process,
it won't go to 64bit check path.
*. And in "adjust_fs_info" function, I think should modify the following code
-       fs->desc_blocks = ext2fs_div_ceil(fs->group_desc_count,
+      fs->desc_blocks = ext2fs_div64_ceil(fs->group_desc_count,
                                           EXT2_DESC_PER_BLOCK(fs->super));

I try to on "EXT4_FEATURE_INCOMPAT_64BIT" and "EXT2_FLAG_64BITS"
when mkfs and resize.
And modify ext2fs_div_ceil code to ext2fs_div64_ceil.
It seems work something, the fs size isn't grow but also not deduce,
remain the same.

If you have any new patch, I can help to test. Thanks.

                                                                        
                  -HsuanTing
Best Regards,
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html