linux-ext4 - problems with large group descriptors and 64bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <C14E4BEF-0064-4E36-975F-B74272E246B1@oracle.com>
Date:	Tue, 22 Jun 2010 17:24:34 -0600
From:	Andreas Dilger <andreas.dilger@...cle.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	"linux-ext4@...r.kernel.org development" <linux-ext4@...r.kernel.org>
Subject: problems with large group descriptors and 64bit

I was just looking through the 64-bit patches that have landed on master, and I see some obvious bugs with the handling of large group descriptors.  In particular, there are some places that still assume they know the group descriptor size, even in the "opaque" routines added by Eric in commit efe0b401465a3ee836180614b5b435acbb84fc27.

lib/ext2fs/open.c assumes ext2_group_desc in a couple of places, instead of calling ext2fs_group_desc() to get the right offset:
#ifdef WORDS_BIGENDIAN  
                gdp = (struct ext2_group_desc *) dest;
                for (j=0; j < groups_per_block*first_meta_bg; j++)
                        ext2fs_swap_group_desc2(fs, gdp++);
#endif


lib/ext2fs/blknum.c assumes 64BIT means ext4_group_desc, not s_desc_size:
struct ext2_group_desc *ext2fs_group_desc(ext2_filsys fs,
                                          struct opaque_ext2_group_desc *gdp,
                                          dgrp_t group)
{               
        if (fs->super->s_desc_size >= EXT2_MIN_DESC_SIZE_64BIT)
                return (struct ext2_group_desc *)
                        ((struct ext4_group_desc *) gdp + group);
        else
                return (struct ext2_group_desc *) gdp + group;
}




Cheers, Andreas
--
Andreas Dilger
Lustre Technical Lead
Oracle Corporation Canada Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html