linux-ext4 - Re: [BUG] ext4 trace events cause NULL pointer dereferences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100723144549.88BA.A69D9226@jp.fujitsu.com>
Date:	Fri, 23 Jul 2010 14:47:33 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	"Ted Ts'o" <tytso@....edu>, Christoph Hellwig <hch@...radead.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>, linux-ext4@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>
Cc:	kosaki.motohiro@...fujitsu.com
Subject: Re: [BUG] ext4 trace events cause NULL pointer dereferences

> On Thu, Jul 22, 2010 at 01:49:57AM -0400, Christoph Hellwig wrote:
> > 
> > I think ext4 is simply using an incorrectly typed tracepoint here.
> > If you want it to be useful in any way it needs a sb paramter and
> > an optional inode paramter, not the allocation context.
> 
> I agree; this is the patch that I had whipped up to fix the problem.
> (See below)

I'm not familiar ext4 so much. but you patch seems very nice!
thank you :)

> 
> > Also the whole ext4_mb_release_group_pa function seems to be a bit
> > misdesigned.  The code using ac is a totally separate block at the
> > end of the function and does work that's unrelated to the rest
> > of the function.  Just making it a separate helper can calling it
> > only from those places that have the allocation context would make
> > the code more clear.
> 
> I need to look more closely at this.  If I had time there would be a
> lot of things that I'd be refactoring and cleaning up in mballoc.c....


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html