linux-ext4 - Re: [PATCH][BUG] ext4: fix returning with 0 from write system call on ext4 with noextent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3CB5D95F-5CAB-4ED3-9837-3DF2DF69FA6D@oracle.com>
Date:	Sun, 25 Jul 2010 20:55:36 -0600
From:	Andreas Dilger <andreas.dilger@...cle.com>
To:	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
Cc:	"tytso@....edu" <tytso@....edu>,
	"adilger@....com" <adilger@....com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"sandeen@...hat.com" <sandeen@...hat.com>
Subject: Re: [PATCH][BUG] ext4: fix returning with 0 from write system call on ext4 with noextent

On 2010-07-25, at 20:16, Toshiyuki Okajima <toshi.okajima@...fujitsu.com> wrote:
> 
> -        if (pos > sbi->s_bitmap_maxbytes)
> +        if (pos > sbi->s_bitmap_maxbytes
> +           || (pos == sbi->s_bitmap_maxbytes && length > 0))
>            return -EFBIG;

Minor note - the kernel coding style is to put the '||' at the end of the first line instead of the start of the second line. 

I thunk it would also be sufficient to do:

        if (pos > sbi->s_bitmap_maxbytes + !!length)
                 return -EFBIG;--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html