linux-ext4 - Re: [PATCH 1/5] Add helper function for blkdev_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <60EEB7F1-715A-4952-87ED-DFEE46B0C0D0@dilger.ca>
Date:	Wed, 8 Sep 2010 14:36:55 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4@...r.kernel.org, rwheeler@...hat.com,
	sandeen@...hat.com, tytso@....edu
Subject: Re: [PATCH 1/5] Add helper function for blkdev_issue_zeroout

On 2010-09-08, at 10:59, Lukas Czerner wrote:
> +static inline int sb_issue_zeroout(struct super_block *sb,
> +				   sector_t block, sector_t nr_blocks)
> +{
> +	block <<= (sb->s_blocksize_bits - 9);
> +	nr_blocks <<= (sb->s_blocksize_bits - 9);
> +	return blkdev_issue_zeroout(sb->s_bdev, block, nr_blocks, GFP_KERNEL,
> +				   BLKDEV_IFL_WAIT | BLKDEV_IFL_BARRIER);
> +}

While I can understand that we might need a barrier for this (to avoid
it being reordered with later writes that are using these blocks), I'm
not sure it needs to wait for previous IO to complete.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html