linux-ext4 - [PATCH 2/2] ext4: remove unused ext4_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4C91102E.6020708@redhat.com>
Date:	Wed, 15 Sep 2010 13:27:58 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH 2/2] ext4: remove unused ext4_error_file()

ext4_error_file is not used, so nuke it for now.

Signed-off-by: Eric Sandeen <sandeen@...hat.com>
---

 ext4.h  |    6 ------
 super.c |   27 ---------------------------
 2 files changed, 33 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index cb4d204..41dbcff 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -62,9 +62,6 @@
 #define EXT4_ERROR_INODE_BLOCK(inode, block, fmt, a...)			\
 	ext4_error_inode((inode), __func__, __LINE__, (block), (fmt), ## a)
 
-#define EXT4_ERROR_FILE(file, fmt, a...)	\
-	ext4_error_file(__func__, __LINE__, (file), (fmt), ## a)
-
 /* data type for block offset of block group */
 typedef int ext4_grpblk_t;
 
@@ -1686,9 +1683,6 @@ extern void __ext4_error(struct super_block *, const char *, unsigned int,
 extern void ext4_error_inode(struct inode *, const char *, unsigned int,
 			     ext4_fsblk_t, const char *, ...)
 	__attribute__ ((format (printf, 5, 6)));
-extern void ext4_error_file(struct file *, const char *, unsigned int,
-			    const char *, ...)
-	__attribute__ ((format (printf, 4, 5)));
 extern void __ext4_std_error(struct super_block *, const char *,
 			     unsigned int, int);
 extern void __ext4_abort(struct super_block *, const char *, unsigned int,
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 2614774..6c35f64 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -416,33 +416,6 @@ void ext4_error_inode(struct inode *inode, const char *function,
 	ext4_handle_error(inode->i_sb);
 }
 
-void ext4_error_file(struct file *file, const char *function,
-		     unsigned int line, const char *fmt, ...)
-{
-	va_list args;
-	struct ext4_super_block *es;
-	struct inode *inode = file->f_dentry->d_inode;
-	char pathname[80], *path;
-
-	es = EXT4_SB(inode->i_sb)->s_es;
-	es->s_last_error_ino = cpu_to_le32(inode->i_ino);
-	save_error_info(inode->i_sb, function, line);
-	va_start(args, fmt);
-	path = d_path(&(file->f_path), pathname, sizeof(pathname));
-	if (!path)
-		path = "(unknown)";
-	printk(KERN_CRIT
-	       "EXT4-fs error (device %s): %s:%d: inode #%lu "
-	       "(comm %s path %s): ",
-	       inode->i_sb->s_id, function, line, inode->i_ino,
-	       current->comm, path);
-	vprintk(fmt, args);
-	printk("\n");
-	va_end(args);
-
-	ext4_handle_error(inode->i_sb);
-}
-
 static const char *ext4_decode_error(struct super_block *sb, int errno,
 				     char nbuf[16])
 {

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html