lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1285332494-12756-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Date: Fri, 24 Sep 2010 18:18:06 +0530 From: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> To: sfrench@...ibm.com, ffilz@...ibm.com, agruen@...e.de, adilger@....com, sandeen@...hat.com, tytso@....edu, bfields@...i.umich.edu, jlayton@...hat.com Cc: aneesh.kumar@...ux.vnet.ibm.com, linux-fsdevel@...r.kernel.org, nfsv4@...ux-nfs.org, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH -V4 03/11] vfs: Add a comment to inode_permission() From: Andreas Gruenbacher <agruen@...e.de> Signed-off-by: Andreas Gruenbacher <agruen@...e.de> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com> --- fs/namei.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 7cadd07..bf822b8 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -167,7 +167,7 @@ EXPORT_SYMBOL(putname); #endif /* - * This does basic POSIX ACL permission checking + * This does the basic permission checking */ static int acl_permission_check(struct inode *inode, int mask, int (*check_acl)(struct inode *inode, int mask)) @@ -212,7 +212,7 @@ int generic_permission(struct inode *inode, int mask, int ret; /* - * Do the basic POSIX ACL permission checks. + * Do the basic permission checks. */ ret = acl_permission_check(inode, mask, check_acl); if (ret != -EACCES) @@ -246,6 +246,8 @@ int generic_permission(struct inode *inode, int mask, * We use "fsuid" for this, letting us set arbitrary permissions * for filesystem access without changing the "normal" uids which * are used for other things. + * + * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask. */ int inode_permission(struct inode *inode, int mask) { -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists