linux-ext4 - Re: [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3tyld6n1e.fsf@intrepid.localdomain>
Date:	Sun, 26 Sep 2010 08:23:25 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Tracey Dent <tdent48227@...il.com>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl

Tracey Dent <tdent48227@...il.com> writes:

> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -233,8 +233,7 @@ typedef struct ext4_io_end {
>  /*
>   * Structure of a blocks group descriptor
>   */
> -struct ext4_group_desc
> -{
> +struct ext4_group_desc	{
>  	__le32	bg_block_bitmap_lo;	/* Blocks bitmap block */
>  	__le32	bg_inode_bitmap_lo;	/* Inodes bitmap block */

Putting a TAB instead of SPACE before the '{' isn't common here, is it?

> @@ -513,8 +512,8 @@ struct ext4_new_group_data {
>  #define EXT4_IOC_GROUP_EXTEND		_IOW('f', 7, unsigned long)
>  #define EXT4_IOC_GROUP_ADD		_IOW('f', 8, struct ext4_new_group_input)
>  #define EXT4_IOC_MIGRATE		_IO('f', 9)
> - /* note ioctl 10 reserved for an early version of the FIEMAP ioctl */
> - /* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */
> +	/* note ioctl 10 reserved for an early version of the FIEMAP ioctl */
> +	/* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */
>  #define EXT4_IOC_ALLOC_DA_BLKS		_IO('f', 12)

Doesn't look like an improvement to me.


>  static inline __le32 ext4_encode_extra_time(struct timespec *time)
>  {
> -       return cpu_to_le32((sizeof(time->tv_sec) > 4 ?
> -			   (time->tv_sec >> 32) & EXT4_EPOCH_MASK : 0) |
> -                          ((time->tv_nsec << EXT4_EPOCH_BITS) & EXT4_NSEC_MASK));
> +		return cpu_to_le32((sizeof(time->tv_sec) > 4 ?
> +				(time->tv_sec >> 32) & EXT4_EPOCH_MASK : 0) |
> +						((time->tv_nsec << EXT4_EPOCH_BITS) & EXT4_NSEC_MASK));

Wrong level of indentation.

>  static inline void ext4_decode_extra_time(struct timespec *time, __le32 extra)
>  {
> -       if (sizeof(time->tv_sec) > 4)
> +		if (sizeof(time->tv_sec) > 4)

Ditto.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html