lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Sep 2010 08:36:34 +0200 From: Krzysztof Halasa <khc@...waw.pl> To: Tracey Dent <tdent48227@...il.com> Cc: tytso@....edu, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 10/10] Fs: ext4: namei: fixed file of checkpatch/pl warnings and errors Tracey Dent <tdent48227@...il.com> writes: > + printk("%s%3u:%03u hash %8x/%8x ", levels ? "":" ", i, block, hash, range); > + if (!(bh = ext4_bread(NULL,dir, block, 0,&err))) continue; Put a SPACE after the comma. "continue" should usually be on the next line. It doesn't make sense to fix the formatting only partially. BTW I wouldn't trust checkpatch so blindly. Also keep in mind checkpatch is only a tool and that maintainers have full authority to ignore the problems (or "problems") it spews. And I would merge all the changes (which make sense) and send them in one patch - that should increase the odds of it actually being applied. To be honest, fixing the style isn't an easy job. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists