linux-ext4 - Re: [PATCH 1/2] writeback: sync quota after inodes writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101008170806.GA23129@infradead.org>
Date:	Fri, 8 Oct 2010 13:08:06 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Dmitry Monakhov <dmonakhov@...il.com>
Cc:	jaxboe@...ionio.com, linux-fsdevel@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] writeback: sync quota after inodes writeback

On Fri, Oct 08, 2010 at 07:00:26PM +0400, Dmitry Monakhov wrote:
> inode writeback usually result in quota changes especially
> on filesystems with delalloc. So quota_sync() before writeback
> seems pointless. Let's do the job in a natural way.

Yes, that's one reason why we can't use the quota sync callback for XFS,
as we need to do it after the actual sync.  Then again I'm not even
sure we need to bother with a callout from the writeback code.
Following the model of all other quota code filesystems using quota
should probably just call it from their ->sync_fs method.  Note that
this allows allows other optimizations for using the generic quota
code.  dquot_quota_sync currently calls ->sync_fs by itself which
could be optimized away by that design.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html