linux-ext4 - Re: ext3/jbd: Avoid WARN() messages when failing to write the superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101011151748.GI3830@quack.suse.cz>
Date:	Mon, 11 Oct 2010 17:17:48 +0200
From:	Jan Kara <jack@...e.cz>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	djwong@...ibm.com, Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org
Subject: Re: ext3/jbd: Avoid WARN() messages when failing to write the
	superblock

On Mon 11-10-10 10:05:34, Eric Sandeen wrote:
> Darrick J. Wong wrote:
> > This fixes a WARN backtrace in mark_buffer_dirty() that occurs during unmount
> > when the underlying block device is removed.  This bug has been seen on System
> > Z when removing all paths from a multipath-backed ext3 mount; on System P when
> > injecting enough PCI EEH errors to make the SCSI controller go offline; and
> > similar warnings have been seen (and patched) with ext2/ext4.
> > 
> > The super block update from a previous operation has marked the buffer as in
> > error, and the flag has to be cleared before doing the update.  (Similar code
> > already exists in ext4).
> > 
> > Signed-off-by: Darrick J. Wong <djwong@...ibm.com>
> > ---
> 
> Probably worth mentioning the ext4 version is:
> 
> commit 914258bf2cb22bf4336a1b1d90c551b4b11ca5aa
> Author: Theodore Ts'o <tytso@....edu>
> Date:   Mon Oct 6 21:35:40 2008 -0400
> 
>     ext4/jbd2: Avoid WARN() messages when failing to write to the superblock
>     
>     This fixes some very common warnings reported by kerneloops.org
>     
>     Signed-off-by: "Theodore Ts'o" <tytso@....edu>
  Yup. Done. Thanks.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html