linux-ext4 - Re: ext4: do not get s_umount sem on ext4_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101011133723.GB3830@quack.suse.cz>
Date:	Mon, 11 Oct 2010 15:37:29 +0200
From:	Jan Kara <jack@...e.cz>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>, tytso@....edu
Subject: Re: ext4: do not get s_umount sem on ext4_quota_off

On Sat 09-10-10 19:28:39, Dmitry Monakhov wrote:
> It must be already acquired by caller. Fix lock_dep complain.
  The patch is OK, but Ted usually merges ext4 patches (even quota related,
unless they are dependent on other generic quota stuff).

								Honza
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@...il.com>
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index e59eb37..062d1bc 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4107,12 +4107,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
>  
>  static int ext4_quota_off(struct super_block *sb, int type)
>  {
> -	/* Force all delayed allocation blocks to be allocated */
> -	if (test_opt(sb, DELALLOC)) {
> -		down_read(&sb->s_umount);
> +	/* Force all delayed allocation blocks to be allocated.
> +	 * Caller already holds s_umount sem */
> +	if (test_opt(sb, DELALLOC))
>  		sync_filesystem(sb);
> -		up_read(&sb->s_umount);
> -	}
>  
>  	return dquot_quota_off(sb, type);
>  }
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html