lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Oct 2010 14:10:01 +0400 From: Roman Borisov <ext-roman.borisov@...ia.com> To: ext Andreas Dilger <adilger@...ger.ca> CC: Eric Sandeen <sandeen@...hat.com>, linux-ext4@...r.kernel.org Subject: Re: ext3: ext4: Using uninitialized value On 10/13/2010 10:56 PM, ext Andreas Dilger wrote: >> that was introduced with: >> > >> > commit acfa1823d33859b0db77701726c9ca5ccc6e6f25 >> > Author: Andreas Dilger<adilger@...sterfs.com> >> > Date: Thu Jun 23 00:09:45 2005 -0700 >> > >> > [PATCH] Support for dx directories in ext3_get_parent (NFSD) >> > >> > so maybe Andreas knows offhand;) but I think: > Your analysis is correct. I agree it's a bit convoluted, but it avoids replicating a bunch of code. > Thanks a lot! it make sence. But I just wondering why hash = hinfo->hash is located in separate scope where it looks like unitialized. The same situation in namei.c/dx_probe(): if (entry) ext3fs_dirhash(entry->name, entry->len, hinfo); hash = hinfo->hash; I believe that the implementation doesn't allow to use hash value when !entry but why it wasn't designed like: if (entry) { ext3fs_dirhash(entry->name, entry->len, hinfo); hash = hinfo->hash; } for example? Roman -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists