linux-ext4 - Re: [PATCH 1/6] ext4: call mpage_da_submit_io() from mpage_da_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <59D861FB-F630-4F5A-87A3-2E2DFE6FA237@dilger.ca>
Date:	Fri, 22 Oct 2010 12:29:12 -0600
From:	Andreas Dilger <adilger.kernel@...ger.ca>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/6] ext4: call mpage_da_submit_io() from mpage_da_map_blocks()

On 2010-10-22, at 09:29, Theodore Ts'o wrote:
> @@ -2323,10 +2323,13 @@ static int mpage_da_map_blocks(struct mpage_da_data *mpd)
> 		disksize = i_size_read(mpd->inode);
> 	if (disksize > EXT4_I(mpd->inode)->i_disksize) {
> 		ext4_update_i_disksize(mpd->inode, disksize);
> -		return ext4_mark_inode_dirty(handle, mpd->inode);
> +		err = ext4_mark_inode_dirty(handle, mpd->inode);
> +		/* XXX not sure what our error handling straegy is here */

(typo) s/straegy/strategy/

I don't think this is necessarily fatal.  It looks like the only time we can fail from ext4_mark_inode_dirty() is cases of IO errors or bad inode numbers and such (which should have been caught already).   At worst, if the blocks are newly mapped (and referenced directly from the inode) then the new blocks would be leaked and the data would be unreachable.  These should already have marked the filesystem in error, so it may be any error here is irrelevant.

Cheers, Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html