linux-ext4 - Re: [PATCH] ext4: fix lazyinit thread prevent from sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Oct 2010 10:46:34 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4@...r.kernel.org, sandeen@...hat.com
Subject: Re: [PATCH] ext4: fix lazyinit thread prevent from sleep

On Fri, Oct 22, 2010 at 08:57:45PM +0200, Lukas Czerner wrote:
> In my test lazyinit threat (in linux-next tree) consumes too much CPU
> (90%). The reason is that there is a bug preventing the threat to sleep
> and hence it keeps walking the li_request_list until the time for next
> scheduled request comes.
> 
> It is because the next_wakeup is originally set to jiffies - 1 so the
> thread is assuming that there is no reason to sleep, because the time
> for next scheduled event is already came, however that is not true.
> 
> I have fixed that by setting next_wakeup to MAX_JIFFY_OFFSET initially
> and than setting value of the next scheduled request (the one with the
> smallest lr_next_sched value). It has been tested and now the CPU
> utilization of lazyinit thread is under 1% (with one request in the list).
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

Thanks, I've merged this into the lazy-init patch in the ext4 patch queue.

	     	    	      	  	    	  - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html