linux-ext4 - Re: [PATCH 1/2] ext3: don't update sb journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101108121504.GA2971@quack.suse.cz>
Date:	Mon, 8 Nov 2010 13:15:04 +0100
From:	Jan Kara <jack@...e.cz>
To:	Maciej Żenczykowski <zenczykowski@...il.com>
Cc:	linux-ext4@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger@....com>, Jan Kara <jack@...e.cz>,
	Christoph Hellwig <hch@....de>,
	Eric Sandeen <sandeen@...hat.com>,
	Dmitry Monakhov <dmonakhov@...nvz.org>,
	Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH 1/2] ext3: don't update sb journal_devnum when RO dev

On Sun 07-11-10 17:09:24, Maciej Żenczykowski wrote:
> 2010/9/26 Maciej Żenczykowski <zenczykowski@...il.com>:
> > An ext3 filesystem on a read-only device, with an external journal
> > which is at a different device number then recorded in the superblock
> > will fail to honor the read-only setting of the device and trigger
> > a superblock update (write).
> >
> > For example:
> >  - ext3 on a software raid which is in read-only mode
> >  - external journal on a read-write device which has changed device num
> >  - attempt to mount with -o journal_dev=<new_number>
> >  - hits BUG_ON(mddev->ro = 1) in md.c
> >
> > Cc: Theodore Ts'o <tytso@....edu>
> > Signed-off-by: Maciej Żenczykowski <zenczykowski@...il.com>
> > ---
> >  fs/ext3/super.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> > index 5dbf4db..19dfbe9 100644
> > --- a/fs/ext3/super.c
> > +++ b/fs/ext3/super.c
> > @@ -2299,7 +2299,7 @@ static int ext3_load_journal(struct super_block *sb,
> >        EXT3_SB(sb)->s_journal = journal;
> >        ext3_clear_journal_err(sb, es);
> >
> > -       if (journal_devnum &&
> > +       if (!really_read_only && journal_devnum &&
> >            journal_devnum != le32_to_cpu(es->s_journal_dev)) {
> >                es->s_journal_dev = cpu_to_le32(journal_devnum);
> >
> > --
> > 1.7.2.3
> >
> >
> 
> While I can see the ext4 patch at:
> 
>  http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git;a=shortlog
> 
> I can't find the ext3 patch.  Did it get missed?
  Yes, it seems so. I'm taking care of ext3 so please CC me directly for
ext3 fixes. Thanks! I'll merge this fix.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html