linux-ext4 - Re: [PATCH] ext3: Return error code from generic_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1011180946020.3125@dhcp-lab-213.englab.brq.redhat.com>
Date:	Thu, 18 Nov 2010 09:52:51 +0100 (CET)
From:	Lukas Czerner <lczerner@...hat.com>
To:	"Darrick J. Wong" <djwong@...ibm.com>
cc:	"Theodore Ts'o" <tytso@....edu>,
	Lukas Czerner <lczerner@...hat.com>,
	Eric Sandeen <sandeen@...hat.com>,
	"Patrick J. LoPresti" <lopresti@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	Mingming Cao <mcao@...ibm.com>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext3: Return error code from generic_check_addressable

On Tue, 16 Nov 2010, Darrick J. Wong wrote:

> ext3: Return error code from generic_check_accessible
> 
> ext3_fill_super should return the error code that generic_check_accessible
> returns when an error condition occurs.
> 
> Signed-off-by: Darrick J. Wong <djwong@...ibm.com>
> ---
> 
>  fs/ext3/super.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 2fedaf8..960629b 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -1842,13 +1842,15 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
>  		goto failed_mount;
>  	}
>  
> -	if (generic_check_addressable(sb->s_blocksize_bits,
> -				      le32_to_cpu(es->s_blocks_count))) {
> +	err = generic_check_addressable(sb->s_blocksize_bits,
> +					le32_to_cpu(es->s_blocks_count));
> +	if (err) {
>  		ext3_msg(sb, KERN_ERR,
>  			"error: filesystem is too large to mount safely");
>  		if (sizeof(sector_t) < 8)
>  			ext3_msg(sb, KERN_ERR,
>  				"error: CONFIG_LBDAF not enabled");
> +		ret = err;
>  		goto failed_mount;
>  	}
>  
> 

Add Jan Kara to cc list.

-Lukas

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html