linux-ext4 - [PATCH] fix debugfs output for flex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <BFE21949-F817-40EF-8A9C-8B30E0530D4A@dilger.ca>
Date:	Thu, 25 Nov 2010 02:57:34 -0700
From:	Andreas Dilger <adilger.kernel@...ger.ca>
To:	Theodore Tso <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: [PATCH] fix debugfs output for flex_bg bitmap offsets

When running debugfs on a filesystem formatted with flex_bg, it prints out the relative offsets for the bitmaps and inode table badly on 64-bit systems, because the offset is computed as a large positive number instead of being a negative numer (which will not be printed at all):

Group 1: (Blocks 0x8000-0xffff) [INODE_UNINIT, ITABLE_ZEROED]
 Block bitmap at 0x0102 (+4294934786), Inode bitmap at 0x0202 (+4294935042)
 Inode table at 0x037e-0x03fa (+4294935422)

The attached patch prints out the relative offsets for flex_bg groups as the offset within the reported group.  This makes it more clear where the metadata is located, rather than simply printing some large negative number.

Group 1: (Blocks 0x8000-0xffff) [INODE_UNINIT, ITABLE_ZEROED]
 Block bitmap at 0x0102 (group 0 +258), Inode bitmap at 0x0202 (group 0 +514)
 Inode table at 0x037e-0x03fa (group 0 +894)

Signed-off-by: Andreas Dilger <adilger@...ger.ca>
--

Cheers, Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html