linux-ext4 - Re: [PATCH] fix debugfs output for flex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B5F6E86E-D94A-4ECC-9B55-FCE9E219DFF1@oracle.com>
Date:	Fri, 26 Nov 2010 17:33:27 -0700
From:	Andreas Dilger <andreas.dilger@...cle.com>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Theodore Tso <tytso@....edu>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] fix debugfs output for flex_bg bitmap offsets

On 2010-11-25, at 12:09, Andreas Dilger wrote:
> ...with patch this time...

Attached is an updated patch that makes the output a bit more verbose (to avoid line wraps) and doesn't fail the m_raid_opts test (which complains when "(+0)" is printed for each inode table).

> On 2010-11-25, at 02:57, Andreas Dilger wrote:
>> When running debugfs on a filesystem formatted with flex_bg, it prints out the relative offsets for the bitmaps and inode table badly on 64-bit systems, because the offset is computed as a large positive number instead of being a negative numer (which will not be printed at all):
>> 
>> Group 1: (Blocks 0x8000-0xffff) [INODE_UNINIT, ITABLE_ZEROED]
>> Block bitmap at 0x0102 (+4294934786), Inode bitmap at 0x0202 (+4294935042)
>> Inode table at 0x037e-0x03fa (+4294935422)
>> 
>> The attached patch prints out the relative offsets for flex_bg groups as the offset within the reported group.  This makes it more clear where the metadata is located, rather than simply printing some large negative number.
>> 
>> Group 1: (Blocks 0x8000-0xffff) [INODE_UNINIT, ITABLE_ZEROED]
>> Block bitmap at 0x0102 (group 0 +258), Inode bitmap at 0x0202 (group 0 +514)
>> Inode table at 0x037e-0x03fa (group 0 +894)
>> 
>> Signed-off-by: Andreas Dilger <adilger@...ger.ca>
>> --
> 


Cheers, Andreas
--
Andreas Dilger
Lustre Technical Lead
Oracle Corporation Canada Inc.

Download attachment "e2fsprogs-dumpe2fs_flex.patch" of type "application/octet-stream" (2114 bytes)