| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Dec 2010 13:20:29 -0500 From: Ted Ts'o <tytso@....edu> To: Eric Sandeen <sandeen@...hat.com> Cc: ext4 development <linux-ext4@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, Cezary Sliwa <sliwa@...e.cft.edu.pl> Subject: Re: [PATCH] ext2: include fs.h in ext2_fs.h On Fri, Dec 03, 2010 at 10:26:26AM -0600, Eric Sandeen wrote: > As reported by Cezary Sliwa in > https://bugzilla.kernel.org/show_bug.cgi?id=24282 > ext2_fs.h references FS_DIRSYNC_FL etc, but does not > include <linux/fs.h> to define them. This seems ok > for kernelspace builds, but breaks userspace applications > which include ext2_fs.h. > > Reported-by: Cezary Sliwa <sliwa@...e.cft.edu.pl> > Signed-off-by: Eric Sandeen <sandeen@...hat.com> I wonder if we would be better off getting application programs weaned off of trying to use the kernel's version of ext2_fs.h altogether. E2fsprogs ships one which is going to be more uptodate, and works for ext2/ext3/ext4. Certainly if you plan to be using libext2fs (which I would strongly advise for any program hoping to manipulate ext2 filesystem structures directly), you should be using the header file shipped with e2fsprogs. Debian and Ubuntu for example ships /usr/include/ext2fs/ext2_fs.h as part of its e2fslibs-dev package. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists