| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4D0A790A.1080703@redhat.com> Date: Thu, 16 Dec 2010 14:39:38 -0600 From: Eric Sandeen <sandeen@...hat.com> To: "Ted Ts'o" <tytso@....edu> CC: ext4 development <linux-ext4@...r.kernel.org> Subject: Re: [PATCH] e2fsprogs: fix type-punning warnings On 12/15/2010 05:09 PM, Ted Ts'o wrote: > On Tue, Dec 14, 2010 at 01:00:01PM -0600, Eric Sandeen wrote: >> Flags used during RHEL/Fedora builds lead to a couple type-punning >> warnings: >> >> recovery.c: In function 'do_one_pass': >> recovery.c:539: warning: dereferencing type-punned pointer will break strict-aliasing rules >> ./csum.c: In function 'print_csum': >> ./csum.c:170: warning: dereferencing type-punned pointer will break strict-aliasing rules >> >> The two changes below fix this up. >> >> Note that the csum test binary output changes slightly, but this does >> not break any tests. >> >> Signed-off-by: Eric Sandeen <sandeen@...hat.com> > > Thanks, applied. There's also a bone-headed big-endian compile bug > which means I'll be doing an e2fsprogs 1.41.14 shortly. > > - Ted Hm this may need an include of the e2p.h header as well, if built in a pristine buildroot... --- e2fsprogs-1.41.12.orig/lib/ext2fs/csum.c +++ e2fsprogs-1.41.12/lib/ext2fs/csum.c @@ -17,6 +17,7 @@ #include "ext2_fs.h" #include "ext2fs.h" #include "crc16.h" +#include "e2p/e2p.h" #include <assert.h> #ifndef offsetof Sorry about that, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists