linux-ext4 - Re: [PATCH] resize2fs: do not clear resize inode for 0 resvd blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101222185501.GA30115@thunk.org>
Date:	Wed, 22 Dec 2010 13:55:01 -0500
From:	Ted Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] resize2fs: do not clear resize inode for 0 resvd blocks

On Tue, Dec 21, 2010 at 03:32:05PM -0600, Eric Sandeen wrote:
> I ran into odd behavior where mkfs.ext4 of a 16T filesystem would
> create a resize inode with 0 reserved blocks, and mark the resize_inode
> feature.
> 
> A subsequent slight downward resize of the filesystem would remove
> the resize inode, making any further offline resizing impossible.
> 
> This is especially odd in light of the fact that a large downward
> resize (say, to 8T) will actually add blocks to the resize inode -
> so a small resize removes it, a large resize expands it ...
> 
> commit 8ade268cf2fde8629b51bfd1c044a83db88234cd had added this:
> 
>   If the filesystem is grown to the point where the resize_inode is no
>   longer needed, clean it up properly so e2fsck doesn't have to.
> 
> but, it seems e2fsck does not care about this situation, either.
> 
> So, simply leave the resize_inode intact in this case, and everything
> seems to be happy.
> 
> Note, this is for the 1.41.xx branch.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Thanks, applied.

						- Ted


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html