linux-ext4 - Re: Regular ext4 error warning with HD in USB dock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinCBARv6_SjBd5+zCjnTZXg9ggnt+YZyHP3BkQB@mail.gmail.com>
Date:	Fri, 7 Jan 2011 22:39:15 +0200
From:	Amir Goldstein <amir73il@...il.com>
To:	"Ted Ts'o" <tytso@....edu>
Cc:	Ric Wheeler <rwheeler@...hat.com>,
	Rogier Wolff <R.E.Wolff@...wizard.nl>,
	Con Kolivas <kernel@...ivas.org>, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org
Subject: Re: Regular ext4 error warning with HD in USB dock

On Fri, Jan 7, 2011 at 9:43 PM, Amir Goldstein <amir73il@...il.com> wrote:
> On Fri, Jan 7, 2011 at 7:28 AM, Ted Ts'o <tytso@....edu> wrote:
>> Also, the kernel patch seems to write the messages in 256-byte
>> records, whereas the e2fsck patch assumes the messages are packed
>> together in null-terminated packed lines....

I checked again. e2fsck patch DOES read messages in 256-byte records:
+static void e2fsck_print_message_buffer(e2fsck_t ctx)
...
+#define MSGLEN 256
...
+		fputs(buf+offset, stdout);
+		offset += MSGLEN;

>>
>>                                                - Ted
>>
>
> I guess that is the reason I always see only the first message on fsck :-)
> It was always enough information for me though...
> feel free to amend to e2fsck patch to match the kernel side.
>
> Thanks,
> Amir.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html