linux-ext4 - [PATCH] ext4: Fix missing iput for root inode in case of all failed mount paths.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik8jweuA_kDfzY7H=wP-ikSSwdf-FF1NX09DDCT@mail.gmail.com>
Date:	Sat, 15 Jan 2011 23:30:12 -0800
From:	Manish Katiyar <mkatiyar@...il.com>
To:	"Theodore Ts'o" <tytso@....edu>, ext4 <linux-ext4@...r.kernel.org>
Cc:	mkatiyar@...il.com
Subject: [PATCH] ext4: Fix missing iput for root inode in case of all failed
 mount paths.

Fix missing iput for root inode in case of all failed mount paths.
Fixes bug#26752

Signed-off-by: Manish Katiyar <mkatiyar@...il.com>

---
 fs/ext4/super.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index cb10a06..9570fcc 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3587,6 +3587,7 @@ no_journal:
        if (err) {
                ext4_msg(sb, KERN_ERR, "failed to initialize system "
                         "zone (%d)", err);
+               iput(root);
                goto failed_mount4;
        }

@@ -3595,12 +3596,15 @@ no_journal:
        if (err) {
                ext4_msg(sb, KERN_ERR, "failed to initialize mballoc (%d)",
                         err);
+               iput(root);
                goto failed_mount4;
        }

        err = ext4_register_li_request(sb, first_not_zeroed);
-       if (err)
+       if (err) {
+               iput(root);
                goto failed_mount4;
+       }

        sbi->s_kobj.kset = ext4_kset;
        init_completion(&sbi->s_kobj_unregister);
@@ -3609,6 +3613,7 @@ no_journal:
        if (err) {
                ext4_mb_release(sb);
                ext4_ext_release(sb);
+               iput(root);
                goto failed_mount4;
        };

@@ -3648,6 +3653,7 @@ cantfind_ext4:
        goto failed_mount;

 failed_mount4:
+       sb->s_root = NULL;
        ext4_msg(sb, KERN_ERR, "mount failed");
        destroy_workqueue(EXT4_SB(sb)->dio_unwritten_wq);
 failed_mount_wq:
-- 
1.7.1


-- 
Thanks -
Manish
==================================
[$\*.^ -- I miss being one of them
==================================
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html