linux-ext4 - Re: [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110124172020.GB22970@noexit>
Date:	Mon, 24 Jan 2011 09:20:23 -0800
From:	Joel Becker <jlbec@...lplan.org>
To:	Jan Kara <jack@...e.cz>
Cc:	Ted Ts'o <tytso@....edu>, Manish Katiyar <mkatiyar@...il.com>,
	ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to
 return errors and handle them gracefully.

On Mon, Jan 24, 2011 at 02:31:43PM +0100, Jan Kara wrote:
> On Sat 22-01-11 22:29:01, Joel Becker wrote:
> > 	This API is markedly better to read.  Btw, does _nofail() mean no
> > possible failures, or just no memory errors?  If it is no failures, I'd
> > love to see the function become void.
>   jbd2_journal_start can always fail e.g. because the journal is aborted.
> So it really just means no memory failures...

	Then _nofail() is a terrible name, because it can still fail.
Let's call it jbd2_journal_start_nofs(); that's what it is.

Joel

-- 

"Under capitalism, man exploits man.  Under Communism, it's just 
   the opposite."
				 - John Kenneth Galbraith

			http://www.jlbec.org/
			jlbec@...lplan.org
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html