linux-ext4 - [PATCH] __ext4_get_inode_loc: use s_inodes_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1296145986-4985-1-git-send-email-bosong.ly@taobao.com>
Date:	Fri, 28 Jan 2011 00:33:06 +0800
From:	Coly Li <bosong.ly@...bao.com>
To:	linux-ext4@...r.kernel.org
Cc:	Coly Li <bosong.ly@...bao.com>, Theodore Tso <tytso@...gle.com>
Subject: [PATCH] __ext4_get_inode_loc: use s_inodes_per_block directly

In __ext4_get_inode_loc(), inodes_per_block is calculated by
(EXT4_BLOCK_SIZE(sb) / EXT4_INODE_SIZE(sb)). This is unncessary, the
value can be found directly from s_inodes_per_block.

Signed-off-by: Coly Li <bosong.ly@...bao.com>
Cc: Theodore Tso <tytso@...gle.com>
---
 fs/ext4/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 9f7f9e4..837c5a6 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4668,7 +4668,7 @@ static int __ext4_get_inode_loc(struct inode *inode,
 	/*
 	 * Figure out the offset within the block group inode table
 	 */
-	inodes_per_block = (EXT4_BLOCK_SIZE(sb) / EXT4_INODE_SIZE(sb));
+	inodes_per_block = EXT4_SB(sb)->s_inodes_per_block;
 	inode_offset = ((inode->i_ino - 1) %
 			EXT4_INODES_PER_GROUP(sb));
 	block = ext4_inode_table(sb, gdp) + (inode_offset / inodes_per_block);
-- 
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html