linux-ext4 - [Bug 27652] 38-rc1: umount+rmmod cause ext4 error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201101282207.p0SM7vIV004578@demeter1.kernel.org>
Date:	Fri, 28 Jan 2011 22:07:57 GMT
From:	bugzilla-daemon@...zilla.kernel.org
To:	linux-ext4@...r.kernel.org
Subject: [Bug 27652] 38-rc1: umount+rmmod cause ext4 error.

https://bugzilla.kernel.org/show_bug.cgi?id=27652





--- Comment #6 from Eric Sandeen <sandeen@...hat.com>  2011-01-28 22:07:53 ---
Ok it is in fact lazyinit uninit that's falling down, the wait_event is waiting
on something that gets freed.

This fixes it up for me:

Index: linux-2.6/fs/ext4/super.c
===================================================================
--- linux-2.6.orig/fs/ext4/super.c
+++ linux-2.6/fs/ext4/super.c
@@ -77,6 +77,7 @@ static struct dentry *ext4_mount(struct 
                const char *dev_name, void *data);
 static void ext4_destroy_lazyinit_thread(void);
 static void ext4_unregister_li_request(struct super_block *sb);
+static void ext4_clear_request_list(void);

 #if !defined(CONFIG_EXT3_FS) && !defined(CONFIG_EXT3_FS_MODULE) &&
defined(CONFIG_EXT4_USE_FOR_EXT23)
 static struct file_system_type ext3_fs_type = {
@@ -2704,6 +2705,8 @@ static void ext4_unregister_li_request(s
     mutex_unlock(&ext4_li_info->li_list_mtx);
 }

+static struct task_struct *ext4_lazyinit_task;
+
 /*
  * This is the function where ext4lazyinit thread lives. It walks
  * through the request list searching for next scheduled filesystem.
@@ -2772,6 +2775,10 @@ cont_thread:
         if (time_before(jiffies, next_wakeup))
             schedule();
         finish_wait(&eli->li_wait_daemon, &wait);
+        if (kthread_should_stop()) {
+            ext4_clear_request_list();
+            goto exit_thread;
+        }
     }

 exit_thread:
@@ -2796,6 +2803,7 @@ exit_thread:
     wake_up(&eli->li_wait_task);

     kfree(ext4_li_info);
+    ext4_lazyinit_task = NULL;
     ext4_li_info = NULL;
     mutex_unlock(&ext4_li_mtx);

@@ -2818,11 +2826,10 @@ static void ext4_clear_request_list(void

 static int ext4_run_lazyinit_thread(void)
 {
-    struct task_struct *t;
-
-    t = kthread_run(ext4_lazyinit_thread, ext4_li_info, "ext4lazyinit");
-    if (IS_ERR(t)) {
-        int err = PTR_ERR(t);
+    ext4_lazyinit_task = kthread_run(ext4_lazyinit_thread,
+                     ext4_li_info, "ext4lazyinit");
+    if (IS_ERR(ext4_lazyinit_task)) {
+        int err = PTR_ERR(ext4_lazyinit_task);
         ext4_clear_request_list();
         del_timer_sync(&ext4_li_info->li_timer);
         kfree(ext4_li_info);
@@ -2976,13 +2983,7 @@ static void ext4_destroy_lazyinit_thread
     if (!ext4_li_info)
         return;

-    ext4_clear_request_list();
-
-    while (ext4_li_info->li_task) {
-        wake_up(&ext4_li_info->li_wait_daemon);
-        wait_event(ext4_li_info->li_wait_task,
-               ext4_li_info->li_task == NULL);
-    }
+    kthread_stop(ext4_lazyinit_task);
 }

 static int ext4_fill_super(struct super_block *sb, void *data, int silent)

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html